Skip to content

Block sparse SVD #19

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Jun 17, 2025
Merged

Block sparse SVD #19

merged 6 commits into from
Jun 17, 2025

Conversation

mtfishman
Copy link
Member

@mtfishman mtfishman commented Jun 16, 2025

Support block sparse SVD when the blocks have Kronecker structure.

Depends on ITensor/BlockSparseArrays.jl#147.

To do:

  • Add tests.

Copy link

codecov bot commented Jun 16, 2025

Codecov Report

Attention: Patch coverage is 74.00000% with 13 lines in your changes missing coverage. Please review.

Project coverage is 78.76%. Comparing base (77f2331) to head (0c0a1bc).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...seArraysExt/KroneckerArraysBlockSparseArraysExt.jl 72.72% 9 Missing ⚠️
src/fillarrays/kroneckerarray.jl 71.42% 2 Missing ⚠️
src/kroneckerarray.jl 66.66% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #19      +/-   ##
==========================================
- Coverage   79.54%   78.76%   -0.78%     
==========================================
  Files          10       10              
  Lines         572      617      +45     
==========================================
+ Hits          455      486      +31     
- Misses        117      131      +14     
Flag Coverage Δ
docs 0.00% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@mtfishman mtfishman changed the title [WIP] Block sparse SVD Block sparse SVD Jun 17, 2025
@mtfishman mtfishman marked this pull request as ready for review June 17, 2025 13:24
@mtfishman mtfishman merged commit ca8be69 into main Jun 17, 2025
12 of 14 checks passed
@mtfishman mtfishman deleted the mf/generalize_svd branch June 17, 2025 15:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant